Viewing Issue Advanced Details Jump to Notes ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000186 [libFirm] buildsystem major always 2016-11-29 11:07 2016-12-01 10:15
Reporter ubdfd View Status public  
Assigned To mohr
Priority normal Resolution fixed Platform
Status resolved   OS
Projection none   OS Version
ETA none Fixed in Version development Product Version development
  Product Build
Summary 0000186: CMakeLists.txt is outdated and doesn't work on Windows [patch included]
Description On current master, the CMakeLists.txt is outdated. A few files are missing from the SOURCES list, the unit tests are not executable via CMake and the Linker flags required to build on Windows are missing. [1] While I was at it, I also took the liberty of removing all POSIX includes, because none of them are actually used.

The attached patch fixes all issues mentioned above.

[1] Note that this path does not make libfirm fully compatible with Windows; most unit tests are still failing. If I find the time, I will investigate why. I'm also assuming that Windows users installed the following regex.h implementation for MinGW: https://sourceforge.net/projects/mingw/files/Other/UserContributed/regex/mingw-regex-2.5.1/ [^]
Steps To Reproduce
Additional Information
Tags No tags attached.
Attached Files ? file icon moritz.patch [^] (2,926 bytes) 2016-11-29 11:07

- Relationships

-  Notes
(0000280)
mohr (developer)
2016-12-01 10:14

Thanks for the patch, fixed in 5a89d4b83cdf70286bfc338f98527ace8bbc4c60.

Yes, past Windows users of libfirm installed the referenced regex implementation.

- Issue History
Date Modified Username Field Change
2016-11-29 11:07 ubdfd New Issue
2016-11-29 11:07 ubdfd File Added: moritz.patch
2016-12-01 10:14 mohr Note Added: 0000280
2016-12-01 10:15 mohr Status new => resolved
2016-12-01 10:15 mohr Fixed in Version => development
2016-12-01 10:15 mohr Resolution open => fixed
2016-12-01 10:15 mohr Assigned To => mohr


Mantis 1.1.5[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker